[Webkit-unassigned] [Bug 147124] Fix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawingArea

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147124

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257135|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 257135
  --> https://bugs.webkit.org/attachment.cgi?id=257135
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257135&action=review

> Source/WebKit2/WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:78
> +void RemoteLayerTreeDisplayRefreshMonitor::clearDrawingArea()
> +{
> +    m_drawingArea = nullptr;
> +}

You don't need this. The WeakPtr does this for you.

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:95
> +    for (RemoteLayerTreeDisplayRefreshMonitor* monitor : m_displayRefreshMonitors)
> +        monitor->clearDrawingArea();

This is not needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150720/cb68b058/attachment.html>