<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawingArea"
href="https://bugs.webkit.org/show_bug.cgi?id=147124">bug 147124</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257135 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawingArea"
href="https://bugs.webkit.org/show_bug.cgi?id=147124#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawingArea"
href="https://bugs.webkit.org/show_bug.cgi?id=147124">bug 147124</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257135&action=diff" name="attach_257135" title="Patch">attachment 257135</a> <a href="attachment.cgi?id=257135&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257135&action=review">https://bugs.webkit.org/attachment.cgi?id=257135&action=review</a>
<span class="quote">> Source/WebKit2/WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:78
> +void RemoteLayerTreeDisplayRefreshMonitor::clearDrawingArea()
> +{
> + m_drawingArea = nullptr;
> +}</span >
You don't need this. The WeakPtr does this for you.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:95
> + for (RemoteLayerTreeDisplayRefreshMonitor* monitor : m_displayRefreshMonitors)
> + monitor->clearDrawingArea();</span >
This is not needed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>