[Webkit-unassigned] [Bug 147082] Install twisted package for http server when necessary.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147082

--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 257054
  --> https://bugs.webkit.org/attachment.cgi?id=257054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257054&action=review

>> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:12
>> +    from webkitpy.common.system.autoinstall import AutoInstaller
> 
> Why don't we modify __init__.py in autoinstalled instead?
> What happens if we've already installed twisted in that directory by using buildbot?

If we've installed twisted, we'll not catch ImportError.
If we modify __init__.py, how do we invoke the installation process? 
Do you mean we import autoinstall module in benchmark runner and it will check the installation of twisted and install it if necessary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150719/91d18a62/attachment.html>