<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Install twisted package for http server when necessary."
href="https://bugs.webkit.org/show_bug.cgi?id=147082#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Install twisted package for http server when necessary."
href="https://bugs.webkit.org/show_bug.cgi?id=147082">bug 147082</a>
from <span class="vcard"><a class="email" href="mailto:dewei_zhu@apple.com" title="dewei_zhu@apple.com">dewei_zhu@apple.com</a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257054&action=diff" name="attach_257054" title="Patch">attachment 257054</a> <a href="attachment.cgi?id=257054&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257054&action=review">https://bugs.webkit.org/attachment.cgi?id=257054&action=review</a>
<span class="quote">>> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:12
>> + from webkitpy.common.system.autoinstall import AutoInstaller
>
> Why don't we modify __init__.py in autoinstalled instead?
> What happens if we've already installed twisted in that directory by using buildbot?</span >
If we've installed twisted, we'll not catch ImportError.
If we modify __init__.py, how do we invoke the installation process?
Do you mean we import autoinstall module in benchmark runner and it will check the installation of twisted and install it if necessary?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>