[Webkit-unassigned] [Bug 147051] Add support for new.target.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147051

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256994|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 256994
  --> https://bugs.webkit.org/attachment.cgi?id=256994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256994&action=review

Looks nice! only few nits.

> Source/JavaScriptCore/parser/Parser.cpp:2929
> +    if (newCount && m_token.m_type == DOT) {

Let's use `match(DOT)`.

> Source/JavaScriptCore/parser/Parser.cpp:2931
> +        const Identifier* ident = m_token.m_data.ident;

Before extracting ident* from m_token, using `if (match(IDENT))` is preferable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150718/bfeae01b/attachment.html>