<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for new.target."
href="https://bugs.webkit.org/show_bug.cgi?id=147051">bug 147051</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256994 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for new.target."
href="https://bugs.webkit.org/show_bug.cgi?id=147051#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for new.target."
href="https://bugs.webkit.org/show_bug.cgi?id=147051">bug 147051</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256994&action=diff" name="attach_256994" title="Patch">attachment 256994</a> <a href="attachment.cgi?id=256994&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256994&action=review">https://bugs.webkit.org/attachment.cgi?id=256994&action=review</a>
Looks nice! only few nits.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2929
> + if (newCount && m_token.m_type == DOT) {</span >
Let's use `match(DOT)`.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2931
> + const Identifier* ident = m_token.m_data.ident;</span >
Before extracting ident* from m_token, using `if (match(IDENT))` is preferable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>