[Webkit-unassigned] [Bug 147001] AX: iframe within table cell is inaccessible to VoiceOver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147001

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256957|review?                     |review-
              Flags|                            |

--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 256957
  --> https://bugs.webkit.org/attachment.cgi?id=256957
new patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256957&action=review

> Source/WebCore/ChangeLog:10
> +        the table cell may cache the wrong role. Fix that allowing each table cell to update its role

Fix that "by" allowing

> Source/WebCore/accessibility/AccessibilityTable.cpp:418
> +        if (row->roleValue() != RowRole)

no need to check the role value since you're iterating rows and you know all the things are rows

> Source/WebCore/accessibility/AccessibilityTable.cpp:422
> +                cell->updateAccessibilityRole();

is updateAccessibilityRole() a method on AccessibilityObject? if so, then no need to check if AccessibilityTableCell, you can just call it

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150717/82bd4bde/attachment.html>