<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: iframe within table cell is inaccessible to VoiceOver"
href="https://bugs.webkit.org/show_bug.cgi?id=147001">bug 147001</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256957 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: iframe within table cell is inaccessible to VoiceOver"
href="https://bugs.webkit.org/show_bug.cgi?id=147001#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: iframe within table cell is inaccessible to VoiceOver"
href="https://bugs.webkit.org/show_bug.cgi?id=147001">bug 147001</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256957&action=diff" name="attach_256957" title="new patch">attachment 256957</a> <a href="attachment.cgi?id=256957&action=edit" title="new patch">[details]</a></span>
new patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256957&action=review">https://bugs.webkit.org/attachment.cgi?id=256957&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:10
> + the table cell may cache the wrong role. Fix that allowing each table cell to update its role</span >
Fix that "by" allowing
<span class="quote">> Source/WebCore/accessibility/AccessibilityTable.cpp:418
> + if (row->roleValue() != RowRole)</span >
no need to check the role value since you're iterating rows and you know all the things are rows
<span class="quote">> Source/WebCore/accessibility/AccessibilityTable.cpp:422
> + cell->updateAccessibilityRole();</span >
is updateAccessibilityRole() a method on AccessibilityObject? if so, then no need to check if AccessibilityTableCell, you can just call it</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>