[Webkit-unassigned] [Bug 147043] Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147043

--- Comment #4 from Jason Marcell <jmarcell at apple.com> ---
Thanks for your feedback, Dan. I'll be sending a new patch soon.

However, in my testing I found some assertions which this changes causes to fail, and which seem to contradict our assumption that combined queues should not have a dictionary of branches. This is in the constructor for BuildbotCombinedQueueView

BuildbotCombinedQueueView = function(queue)
{
    for (var i = 1, end = queue.combinedQueues.length; i < end; ++i) {
        console.assert(queue.combinedQueues[0].buildbot === queue.combinedQueues[i].buildbot);
        console.assert(queue.combinedQueues[0].branch.openSource === queue.combinedQueues[i].branch.openSource);
        console.assert(queue.combinedQueues[0].branch.internal === queue.combinedQueues[i].branch.internal);
    }

I've just finished looking over the codebase for usages of .branch and I don't see any reason why we need to make this assertion.

Do you agree that we should remove these assertions?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150717/24778282/attachment.html>