<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043">bug 147043</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>Thanks for your feedback, Dan. I'll be sending a new patch soon.
However, in my testing I found some assertions which this changes causes to fail, and which seem to contradict our assumption that combined queues should not have a dictionary of branches. This is in the constructor for BuildbotCombinedQueueView
BuildbotCombinedQueueView = function(queue)
{
for (var i = 1, end = queue.combinedQueues.length; i < end; ++i) {
console.assert(queue.combinedQueues[0].buildbot === queue.combinedQueues[i].buildbot);
console.assert(queue.combinedQueues[0].branch.openSource === queue.combinedQueues[i].branch.openSource);
console.assert(queue.combinedQueues[0].branch.internal === queue.combinedQueues[i].branch.internal);
}
I've just finished looking over the codebase for usages of .branch and I don't see any reason why we need to make this assertion.
Do you agree that we should remove these assertions?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>