[Webkit-unassigned] [Bug 147043] Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147043

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 256978
  --> https://bugs.webkit.org/attachment.cgi?id=256978
Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.

View in context: https://bugs.webkit.org/attachment.cgi?id=256978&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:98
> +    get defaultBranches() {

Please move curly brace ('{'} to its own line. See the setter isAuthenticated() (below) for an example.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:78
> +    _getDefaultBranches: function() {

Ditto.

> Tools/ChangeLog:15
> +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
> +        (Buildbot.prototype._getDefaultBranches):
> +        base class method to return empty dictionary
> +        (Buildbot.prototype._normalizeQueueInfo):
> +        Calls _getDefaultBranches instead of hardcoded values
> +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
> +        (WebKitBuildbot.prototype._getDefaultBranches):
> +        overrides base class and provides a webkit-specific implementation that only cares about "opensource"

This change log entry is out-of-date. Please update it. Also, please write complete sentences that start with a capital letter and end with a period.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150717/ae556078/attachment-0001.html>