<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043">bug 147043</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256978&action=diff" name="attach_256978" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">attachment 256978</a> <a href="attachment.cgi?id=256978&action=edit" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">[details]</a></span>
Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256978&action=review">https://bugs.webkit.org/attachment.cgi?id=256978&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:98
> + get defaultBranches() {</span >
Please move curly brace ('{'} to its own line. See the setter isAuthenticated() (below) for an example.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:78
> + _getDefaultBranches: function() {</span >
Ditto.
<span class="quote">> Tools/ChangeLog:15
> + * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
> + (Buildbot.prototype._getDefaultBranches):
> + base class method to return empty dictionary
> + (Buildbot.prototype._normalizeQueueInfo):
> + Calls _getDefaultBranches instead of hardcoded values
> + * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
> + (WebKitBuildbot.prototype._getDefaultBranches):
> + overrides base class and provides a webkit-specific implementation that only cares about "opensource"</span >
This change log entry is out-of-date. Please update it. Also, please write complete sentences that start with a capital letter and end with a period.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>