[Webkit-unassigned] [Bug 147008] Media Session: add support for platform-specific interruption providers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147008

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 256916
  --> https://bugs.webkit.org/attachment.cgi?id=256916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256916&action=review

> Source/WebCore/ChangeLog:9
> +        * platform/audio/MediaSessionInterruptionProvider.cpp: Added base class to be used by MediaSessionManager to

Nit: This isn't audio-specific, so why don't you put it into a new "platform/mediasession" directory?

> Source/WebCore/platform/audio/MediaSessionInterruptionProvider.cpp:37
> +MediaSessionInterruptionProvider::MediaSessionInterruptionProvider(MediaSessionInterruptionProviderClient& client)
> +    : m_client(&client)
> +{
> +    beginListeningForInterruptions();
> +}

Will there ever be more than one interruption provider? If so, what is the lifetime of an object - who creates it?

If there will only ever be one, you need a static accessor method and you need a way to add/remove clients.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150716/c8d8b7da/attachment.html>