<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add support for platform-specific interruption providers"
href="https://bugs.webkit.org/show_bug.cgi?id=147008#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add support for platform-specific interruption providers"
href="https://bugs.webkit.org/show_bug.cgi?id=147008">bug 147008</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256916&action=diff" name="attach_256916" title="Patch">attachment 256916</a> <a href="attachment.cgi?id=256916&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256916&action=review">https://bugs.webkit.org/attachment.cgi?id=256916&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:9
> + * platform/audio/MediaSessionInterruptionProvider.cpp: Added base class to be used by MediaSessionManager to</span >
Nit: This isn't audio-specific, so why don't you put it into a new "platform/mediasession" directory?
<span class="quote">> Source/WebCore/platform/audio/MediaSessionInterruptionProvider.cpp:37
> +MediaSessionInterruptionProvider::MediaSessionInterruptionProvider(MediaSessionInterruptionProviderClient& client)
> + : m_client(&client)
> +{
> + beginListeningForInterruptions();
> +}</span >
Will there ever be more than one interruption provider? If so, what is the lifetime of an object - who creates it?
If there will only ever be one, you need a static accessor method and you need a way to add/remove clients.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>