[Webkit-unassigned] [Bug 146448] JavaScriptCore performance is very bad on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146448

--- Comment #32 from peavo at outlook.com ---
(In reply to comment #26)
> Comment on attachment 256896 [details]
> Patch

Thanks again for reviewing :)

> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256896&action=review
> 
> Per, there are 2 changes here:
> 1. Replacing use of std::thread::id with WTF::ThreadIdentifier.
> 2. Optimizing out the computation of stack bounds when still in the same
> Windows fiber.
> 
> Can you (or someone) please confirm that (1) actually contributes to the
> performance difference you’re seeing?  These 2 changes should be tested
> separately to measure their effects.
> 

I first made change 2. The sprite count in this benchmark then went from 120 to ~300.
Next I made change 1. The sprite count then increased from 300 to ~3000.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150716/285ce56d/attachment.html>