<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore performance is very bad on Windows"
href="https://bugs.webkit.org/show_bug.cgi?id=146448#c32">Comment # 32</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore performance is very bad on Windows"
href="https://bugs.webkit.org/show_bug.cgi?id=146448">bug 146448</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146448#c26">comment #26</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=256896&action=diff" name="attach_256896" title="Patch">attachment 256896</a> <a href="attachment.cgi?id=256896&action=edit" title="Patch">[details]</a></span>
> Patch</span >
Thanks again for reviewing :)
<span class="quote">>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256896&action=review">https://bugs.webkit.org/attachment.cgi?id=256896&action=review</a>
>
> Per, there are 2 changes here:
> 1. Replacing use of std::thread::id with WTF::ThreadIdentifier.
> 2. Optimizing out the computation of stack bounds when still in the same
> Windows fiber.
>
> Can you (or someone) please confirm that (1) actually contributes to the
> performance difference you’re seeing? These 2 changes should be tested
> separately to measure their effects.
> </span >
I first made change 2. The sprite count in this benchmark then went from 120 to ~300.
Next I made change 1. The sprite count then increased from 300 to ~3000.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>