[Webkit-unassigned] [Bug 146953] Negative scroll snap repeat values cause web process to hang indefinitely

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146953

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 256818
  --> https://bugs.webkit.org/attachment.cgi?id=256818
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256818&action=review

>> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:20
>> +            #item5 { background-color: fuchsia; }
> 
> Not needed.

I left these in because the length of the scrollable content must be greater than the length of the viewport in order to trigger the code path that computes scroll snap offsets (otherwise, the while loop that causes the infinite loop won't be run and the test will pass even without this patch). However, I can make this a bit simpler -- instead of 6 elements, I can just have one really long one.

>> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:30
>> +        <div id="item5" class="colorBox"></div>
> 
> You still don't need these.

Good point -- took out the colors.

>> LayoutTests/css3/scroll-snap/scroll-snap-subpixel-repeat.html:56
>> +                testRunner.notifyDone();
> 
> finishJSTest calls notifyDone for you.

Got it. I'll remember that for next time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150715/700bfe08/attachment-0001.html>