<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953">bug 146953</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256818&action=diff" name="attach_256818" title="Patch">attachment 256818</a> <a href="attachment.cgi?id=256818&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256818&action=review">https://bugs.webkit.org/attachment.cgi?id=256818&action=review</a>
<span class="quote">>> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:20
>> + #item5 { background-color: fuchsia; }
>
> Not needed.</span >
I left these in because the length of the scrollable content must be greater than the length of the viewport in order to trigger the code path that computes scroll snap offsets (otherwise, the while loop that causes the infinite loop won't be run and the test will pass even without this patch). However, I can make this a bit simpler -- instead of 6 elements, I can just have one really long one.
<span class="quote">>> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:30
>> + <div id="item5" class="colorBox"></div>
>
> You still don't need these.</span >
Good point -- took out the colors.
<span class="quote">>> LayoutTests/css3/scroll-snap/scroll-snap-subpixel-repeat.html:56
>> + testRunner.notifyDone();
>
> finishJSTest calls notifyDone for you.</span >
Got it. I'll remember that for next time.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>