[Webkit-unassigned] [Bug 146953] Negative scroll snap repeat values cause web process to hang indefinitely

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146953

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 256816
  --> https://bugs.webkit.org/attachment.cgi?id=256816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256816&action=review

>> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:90
>> +    LayoutUnit repeatOffset = points ? valueForLength(points->repeatOffset, viewSize) : LayoutUnit(1.0f);
> 
> LayoutUnit(1.0f) should be LayoutUnit::fromPixel(1)

Fixed!

>> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:92
>> +        repeatOffset = LayoutUnit(1.0f);
> 
> repeatOffset = std::min<LayoutUnit>(repeatOffset, 1);

Fixed! (I assumed std::min was meant to be std::max?)

>> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:39
>> +        </div>
> 
> Not sure that any of this is needed. Can't you just have body { -webkit-scroll-snap-type: mandatory; -webkit-scroll-snap-points-y: repeat(-400px); }

Good point -- fixed!

>> LayoutTests/css3/scroll-snap/scroll-snap-subpixel-repeat.html:10
>> +                -webkit-overflow-scrolling: touch;
> 
> Remove this.

Removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150715/765af04c/attachment-0001.html>