<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953">bug 146953</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256816&action=diff" name="attach_256816" title="Patch">attachment 256816</a> <a href="attachment.cgi?id=256816&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256816&action=review">https://bugs.webkit.org/attachment.cgi?id=256816&action=review</a>
<span class="quote">>> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:90
>> + LayoutUnit repeatOffset = points ? valueForLength(points->repeatOffset, viewSize) : LayoutUnit(1.0f);
>
> LayoutUnit(1.0f) should be LayoutUnit::fromPixel(1)</span >
Fixed!
<span class="quote">>> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:92
>> + repeatOffset = LayoutUnit(1.0f);
>
> repeatOffset = std::min<LayoutUnit>(repeatOffset, 1);</span >
Fixed! (I assumed std::min was meant to be std::max?)
<span class="quote">>> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:39
>> + </div>
>
> Not sure that any of this is needed. Can't you just have body { -webkit-scroll-snap-type: mandatory; -webkit-scroll-snap-points-y: repeat(-400px); }</span >
Good point -- fixed!
<span class="quote">>> LayoutTests/css3/scroll-snap/scroll-snap-subpixel-repeat.html:10
>> + -webkit-overflow-scrolling: touch;
>
> Remove this.</span >
Removed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>