[Webkit-unassigned] [Bug 146916] Input buttons rendered at the wrong size when pinching-to-zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146916

--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 256772
  --> https://bugs.webkit.org/attachment.cgi?id=256772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256772&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:610
> +        if (shouldUseImageBuffer) {
> +            drawCellFocusRing(buttonCell, CGRectMake(focusThickness, focusThickness, inflatedRect.width(), inflatedRect.height()), view);
> +            context->drawImageBuffer(imageBuffer.get(), ColorSpaceDeviceRGB, inflatedRect.location() - FloatSize(focusThickness, focusThickness));
> +        } else
> +            drawCellFocusRing(buttonCell, inflatedRect, view);
> +    }
> +    
> +    controlStates->setNeedsRepaint(false);

While we disabled animating the focus ring during the last cycle, I think we should at least keep this part of the logic in place. i.e. that drawCellFocusRing returns a boolean that we use to set needsRepaint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150714/e5e4898b/attachment.html>