<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Input buttons rendered at the wrong size when pinching-to-zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=146916#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Input buttons rendered at the wrong size when pinching-to-zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=146916">bug 146916</a>
from <span class="vcard"><a class="email" href="mailto:dino@apple.com" title="Dean Jackson <dino@apple.com>"> <span class="fn">Dean Jackson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256772&action=diff" name="attach_256772" title="Patch">attachment 256772</a> <a href="attachment.cgi?id=256772&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256772&action=review">https://bugs.webkit.org/attachment.cgi?id=256772&action=review</a>
<span class="quote">> Source/WebCore/platform/mac/ThemeMac.mm:610
> + if (shouldUseImageBuffer) {
> + drawCellFocusRing(buttonCell, CGRectMake(focusThickness, focusThickness, inflatedRect.width(), inflatedRect.height()), view);
> + context->drawImageBuffer(imageBuffer.get(), ColorSpaceDeviceRGB, inflatedRect.location() - FloatSize(focusThickness, focusThickness));
> + } else
> + drawCellFocusRing(buttonCell, inflatedRect, view);
> + }
> +
> + controlStates->setNeedsRepaint(false);</span >
While we disabled animating the focus ring during the last cycle, I think we should at least keep this part of the logic in place. i.e. that drawCellFocusRing returns a boolean that we use to set needsRepaint.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>