[Webkit-unassigned] [Bug 146837] Media Session: add plumbing for delivering start/end-of-interruption events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146837

--- Comment #19 from Tim Horton <thorton at apple.com> ---
(In reply to comment #17)
> (In reply to comment #16)
> > Comment on attachment 256708 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=256708&action=review
> > 
> > > Source/WebKit2/UIProcess/API/C/WKPage.cpp:2193
> > > +// NOTE: The values in the WKMediaSessionInterruptingCategory enum must stay in sync with those in WebCore::MediaSessionInterruptingCategory.
> > 
> > Why must they? You do a proper conversion below.
> 
> We cast from a WKMediaSessionInterruptionEvent to a
> MediaSessionInterruptionEvent in WebPage.cpp. We need to ensure the enums'
> values are the same, otherwise we'll get them mixed up after casting.

I'm not sure why we have a proper conversion function in one direction and just cast in the other direction?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150713/b949443a/attachment.html>