<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Media Session: add plumbing for delivering start/end-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Media Session: add plumbing for delivering start/end-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837">bug 146837</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146837#c17">comment #17</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=146837#c16">comment #16</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=256708&action=diff" name="attach_256708" title="Patch">attachment 256708</a> <a href="attachment.cgi?id=256708&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=256708&action=review">https://bugs.webkit.org/attachment.cgi?id=256708&action=review</a>
> >
> > > Source/WebKit2/UIProcess/API/C/WKPage.cpp:2193
> > > +// NOTE: The values in the WKMediaSessionInterruptingCategory enum must stay in sync with those in WebCore::MediaSessionInterruptingCategory.
> >
> > Why must they? You do a proper conversion below.
>
> We cast from a WKMediaSessionInterruptionEvent to a
> MediaSessionInterruptionEvent in WebPage.cpp. We need to ensure the enums'
> values are the same, otherwise we'll get them mixed up after casting.</span >
I'm not sure why we have a proper conversion function in one direction and just cast in the other direction?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>