[Webkit-unassigned] [Bug 146579] Prepare for VS2015

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146579

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 256085
  --> https://bugs.webkit.org/attachment.cgi?id=256085
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256085&action=review

> Source/JavaScriptCore/heap/Heap.h:76
> +static void* const zombifiedBits = reinterpret_cast<void*>(static_cast<size_t>(0xdeadbeef));

I suggest uintptr_t instead of size_t.

> Source/JavaScriptCore/runtime/ConsoleClient.cpp:256
> +// Yeah, I'm not sure why these are needed, but this shouldn't be put into WebKit.  They're in JSCJSValueInlines.h, but the linker complains without them.  I did a 64-bit build.

Most likely the problem is some source file that is not including JSCJSValueInlines.h. That would result in this symptom.

> Source/WTF/wtf/StdLibExtras.h:351
> +#if !defined(_MSC_VER) || _MSC_VER < 1900

Should use COMPILER(MSVC) rather than using _MSC_VER directly, like the rest of the code does.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150711/fdbbd66c/attachment-0001.html>