<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Prepare for VS2015"
href="https://bugs.webkit.org/show_bug.cgi?id=146579#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Prepare for VS2015"
href="https://bugs.webkit.org/show_bug.cgi?id=146579">bug 146579</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256085&action=diff" name="attach_256085" title="patch">attachment 256085</a> <a href="attachment.cgi?id=256085&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256085&action=review">https://bugs.webkit.org/attachment.cgi?id=256085&action=review</a>
<span class="quote">> Source/JavaScriptCore/heap/Heap.h:76
> +static void* const zombifiedBits = reinterpret_cast<void*>(static_cast<size_t>(0xdeadbeef));</span >
I suggest uintptr_t instead of size_t.
<span class="quote">> Source/JavaScriptCore/runtime/ConsoleClient.cpp:256
> +// Yeah, I'm not sure why these are needed, but this shouldn't be put into WebKit. They're in JSCJSValueInlines.h, but the linker complains without them. I did a 64-bit build.</span >
Most likely the problem is some source file that is not including JSCJSValueInlines.h. That would result in this symptom.
<span class="quote">> Source/WTF/wtf/StdLibExtras.h:351
> +#if !defined(_MSC_VER) || _MSC_VER < 1900</span >
Should use COMPILER(MSVC) rather than using _MSC_VER directly, like the rest of the code does.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>