[Webkit-unassigned] [Bug 146837] Media Session: add plumbing for delivering start-of-interruption events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146837

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256610|review?                     |review+
              Flags|                            |

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 256610
  --> https://bugs.webkit.org/attachment.cgi?id=256610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256610&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:2197
> +    switch (wkCategory) {

I realize there's only one user, but the enum conversion functions are usually separate static methods. Maybe just keep that in mind if we end up needing this code again?

> Source/WebKit2/WebProcess/WebPage/WebPage.h:746
> +    void handleStartOfInterruptionEvent(uint32_t /* WebCore::MediaSessionInterruptingCategory */);

Since this is on WebPage, it should be more clear that it's about media. Also, maybe just "handleMediaInterruptionEvent", with a state/phase to indicate whether it's starting or ending? Won't you eventually need the end case too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150710/bd100505/attachment.html>