<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837">bug 146837</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256610 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837">bug 146837</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256610&action=diff" name="attach_256610" title="Patch">attachment 256610</a> <a href="attachment.cgi?id=256610&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256610&action=review">https://bugs.webkit.org/attachment.cgi?id=256610&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/C/WKPage.cpp:2197
> + switch (wkCategory) {</span >
I realize there's only one user, but the enum conversion functions are usually separate static methods. Maybe just keep that in mind if we end up needing this code again?
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.h:746
> + void handleStartOfInterruptionEvent(uint32_t /* WebCore::MediaSessionInterruptingCategory */);</span >
Since this is on WebPage, it should be more clear that it's about media. Also, maybe just "handleMediaInterruptionEvent", with a state/phase to indicate whether it's starting or ending? Won't you eventually need the end case too?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>