[Webkit-unassigned] [Bug 146837] Media Session: add plumbing for delivering start-of-interruption events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146837

--- Comment #5 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #4)
> Comment on attachment 256589 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256589&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSessionEvents.h:33
> > +enum MediaEventType {
> 
> This should be "enum class".

These are "enums" so we can cast to them from WKMediaEventTypes. We can't do that with a strongly-typed "enum class".

> 
> > Source/WebCore/Modules/mediasession/MediaSessionEvents.h:39
> > +enum MediaSessionInterruptingCategory {
> 
> Ditto.
> 
> > Source/WebCore/page/Page.cpp:1230
> > +void Page::handleStartOfInterruptionEvent(MediaSessionInterruptingCategory category)
> > +{
> > +}
> 
> Please add notImplemented();

Added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150710/2fd1947e/attachment.html>