<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
href="https://bugs.webkit.org/show_bug.cgi?id=146837">bug 146837</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146837#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256589&action=diff" name="attach_256589" title="Patch">attachment 256589</a> <a href="attachment.cgi?id=256589&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256589&action=review">https://bugs.webkit.org/attachment.cgi?id=256589&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaSessionEvents.h:33
> > +enum MediaEventType {
>
> This should be "enum class".</span >
These are "enums" so we can cast to them from WKMediaEventTypes. We can't do that with a strongly-typed "enum class".
<span class="quote">>
> > Source/WebCore/Modules/mediasession/MediaSessionEvents.h:39
> > +enum MediaSessionInterruptingCategory {
>
> Ditto.
>
> > Source/WebCore/page/Page.cpp:1230
> > +void Page::handleStartOfInterruptionEvent(MediaSessionInterruptingCategory category)
> > +{
> > +}
>
> Please add notImplemented();</span >
Added.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>