<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
   href="https://bugs.webkit.org/show_bug.cgi?id=146837#c5">Comment # 5</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Media Session: add plumbing for delivering start-of-interruption events"
   href="https://bugs.webkit.org/show_bug.cgi?id=146837">bug 146837</a>
              from <span class="vcard"><a class="email" href="mailto:mrajca&#64;apple.com" title="Matt Rajca &lt;mrajca&#64;apple.com&gt;"> <span class="fn">Matt Rajca</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=146837#c4">comment #4</a>)
<span class="quote">&gt; Comment on <span class=""><a href="attachment.cgi?id=256589&amp;action=diff" name="attach_256589" title="Patch">attachment 256589</a> <a href="attachment.cgi?id=256589&amp;action=edit" title="Patch">[details]</a></span>
&gt; Patch
&gt; 
&gt; View in context:
&gt; <a href="https://bugs.webkit.org/attachment.cgi?id=256589&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=256589&amp;action=review</a>
&gt; 
&gt; &gt; Source/WebCore/Modules/mediasession/MediaSessionEvents.h:33
&gt; &gt; +enum MediaEventType {
&gt; 
&gt; This should be &quot;enum class&quot;.</span >

These are &quot;enums&quot; so we can cast to them from WKMediaEventTypes. We can't do that with a strongly-typed &quot;enum class&quot;.

<span class="quote">&gt; 
&gt; &gt; Source/WebCore/Modules/mediasession/MediaSessionEvents.h:39
&gt; &gt; +enum MediaSessionInterruptingCategory {
&gt; 
&gt; Ditto.
&gt; 
&gt; &gt; Source/WebCore/page/Page.cpp:1230
&gt; &gt; +void Page::handleStartOfInterruptionEvent(MediaSessionInterruptingCategory category)
&gt; &gt; +{
&gt; &gt; +}
&gt; 
&gt; Please add notImplemented();</span >

Added.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>