[Webkit-unassigned] [Bug 145697] [GTK] update-webkitgtk-libs should not pass --no-interact to jhbuild

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145697

--- Comment #1 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to comment #0)
> update-webkitgtk-libs currently passes --no-interact to jhbuild. It's really
> hard to understate how frustrating this it -- it makes jhbuild continue to
> build even after something has failed, and it's very difficult to discover
> why things fail to build, since the error is always long past normal
> terminal scrollback limits. Instead, I expect to immediately get a build
> error with the nice menu that allows me to decide how to fix the problem.
> 
> If the bots need the --no-interact behavior, we'll need to add a flag to
> update-webkitgtk-libs for that.

JHBuild should not ask any question, so no-interact make a lot of sense.

What don't makes sense is that it continues building even when no-interact is enabled.

I have tested this patch and it fixes the problem:

--- a/jhbuild/frontends/terminal.py
+++ b/jhbuild/frontends/terminal.py
@@ -304,7 +304,7 @@ class TerminalBuildScript(buildscript.BuildScript):
         self.triedcheckout = None

         if not self.config.interact:
-            return 'fail'
+            sys.exit(1)
         while True:
             print
             uprint('  [1] %s' % _('Rerun phase %s') % phase)




I see two options:

a) We fork jhbuild (on github for example) and we apply this patch and then we use it as source on the script Tools/jhbuild/jhbuild-wrapper instead of using upstream git://git.gnome.org/jhbuild'

b) We add an extra step on Tools/gtk/jhbuild.modules after cloning the repo to apply a serie of patches.


Which option is preferred? If is the b. I already have it more or less ready, I can upload a patch for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150709/52bd98a1/attachment-0001.html>