<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] update-webkitgtk-libs should not pass --no-interact to jhbuild"
href="https://bugs.webkit.org/show_bug.cgi?id=145697#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] update-webkitgtk-libs should not pass --no-interact to jhbuild"
href="https://bugs.webkit.org/show_bug.cgi?id=145697">bug 145697</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145697#c0">comment #0</a>)
<span class="quote">> update-webkitgtk-libs currently passes --no-interact to jhbuild. It's really
> hard to understate how frustrating this it -- it makes jhbuild continue to
> build even after something has failed, and it's very difficult to discover
> why things fail to build, since the error is always long past normal
> terminal scrollback limits. Instead, I expect to immediately get a build
> error with the nice menu that allows me to decide how to fix the problem.
>
> If the bots need the --no-interact behavior, we'll need to add a flag to
> update-webkitgtk-libs for that.</span >
JHBuild should not ask any question, so no-interact make a lot of sense.
What don't makes sense is that it continues building even when no-interact is enabled.
I have tested this patch and it fixes the problem:
--- a/jhbuild/frontends/terminal.py
+++ b/jhbuild/frontends/terminal.py
@@ -304,7 +304,7 @@ class TerminalBuildScript(buildscript.BuildScript):
self.triedcheckout = None
if not self.config.interact:
- return 'fail'
+ sys.exit(1)
while True:
print
uprint(' [1] %s' % _('Rerun phase %s') % phase)
I see two options:
a) We fork jhbuild (on github for example) and we apply this patch and then we use it as source on the script Tools/jhbuild/jhbuild-wrapper instead of using upstream git://git.gnome.org/jhbuild'
b) We add an extra step on Tools/gtk/jhbuild.modules after cloning the repo to apply a serie of patches.
Which option is preferred? If is the b. I already have it more or less ready, I can upload a patch for review.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>