[Webkit-unassigned] [Bug 146693] Rubber banding is broken when using a Mighty Mouse

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146693

--- Comment #5 from Beth Dakin <bdakin at apple.com> ---
Comment on attachment 256325
  --> https://bugs.webkit.org/attachment.cgi?id=256325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256325&action=review

> Source/WebCore/ChangeLog:1
> +2015-07-07  Wenson Hsieh  <whsieh at berkeley.edu>

You should be using your apple email address here.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1110
> +static bool isStatelessWheelEvent(const PlatformWheelEvent& wheelEvent)

I'm concerned about this phrase "stateless." This does not seem like a good/descriptive-enough name for this to me.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1112
> +    return wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone;

Why is it okay to definitely return early here? Are you certain there is nothing more to do? Has the event already had a chance to be propagated to the DOM? Do we ever get events with this phase configuration for a non-Mighty-mouse? 

This bug, I believe, it unique to overflow scrolling. In other words, it does not happen to the main document. How do we get it right for the main document?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150708/8fc9c99e/attachment.html>