<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Rubber banding is broken when using a Mighty Mouse"
href="https://bugs.webkit.org/show_bug.cgi?id=146693#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Rubber banding is broken when using a Mighty Mouse"
href="https://bugs.webkit.org/show_bug.cgi?id=146693">bug 146693</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256325&action=diff" name="attach_256325" title="Patch">attachment 256325</a> <a href="attachment.cgi?id=256325&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256325&action=review">https://bugs.webkit.org/attachment.cgi?id=256325&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:1
> +2015-07-07 Wenson Hsieh <<a href="mailto:whsieh@berkeley.edu">whsieh@berkeley.edu</a>></span >
You should be using your apple email address here.
<span class="quote">> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1110
> +static bool isStatelessWheelEvent(const PlatformWheelEvent& wheelEvent)</span >
I'm concerned about this phrase "stateless." This does not seem like a good/descriptive-enough name for this to me.
<span class="quote">> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1112
> + return wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone;</span >
Why is it okay to definitely return early here? Are you certain there is nothing more to do? Has the event already had a chance to be propagated to the DOM? Do we ever get events with this phase configuration for a non-Mighty-mouse?
This bug, I believe, it unique to overflow scrolling. In other words, it does not happen to the main document. How do we get it right for the main document?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>