[Webkit-unassigned] [Bug 146660] Media Session: propagate metadata changes to UI clients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146660

--- Comment #8 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #7)
> Comment on attachment 256308 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256308&action=review
> 
> > Source/WebKit2/UIProcess/API/APIUIClient.h:61
> > +#if ENABLE(MEDIA_SESSION)
> 
> no need to guard this forward-declaration (but it's fine either way)

I think I'll leave it in.

> 
> > Source/WebKit2/UIProcess/API/C/WKAPICast.h:112
> > +#if ENABLE(MEDIA_SESSION)
> 
> ditto
> 
> > Source/WebKit2/UIProcess/API/C/WKAPICast.h:171
> > +WK_ADD_API_MAPPING(WKMediaSessionMetadataRef, WebMediaSessionMetadata)
> 
> Why is this mapping #if'd out if WKMediaSessionMetadata has all the
> functions but the contents of said functions are if'd out? Which way are you
> disabling this?

The contents of the functions have to be #if'd out since it doesn't seem like we can use #if ENABLE in those header files. I can remove the #if guards around the mapping.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150707/3ad8ed34/attachment.html>