<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660">bug 146660</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146660#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256308&action=diff" name="attach_256308" title="Patch">attachment 256308</a> <a href="attachment.cgi?id=256308&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256308&action=review">https://bugs.webkit.org/attachment.cgi?id=256308&action=review</a>
>
> > Source/WebKit2/UIProcess/API/APIUIClient.h:61
> > +#if ENABLE(MEDIA_SESSION)
>
> no need to guard this forward-declaration (but it's fine either way)</span >
I think I'll leave it in.
<span class="quote">>
> > Source/WebKit2/UIProcess/API/C/WKAPICast.h:112
> > +#if ENABLE(MEDIA_SESSION)
>
> ditto
>
> > Source/WebKit2/UIProcess/API/C/WKAPICast.h:171
> > +WK_ADD_API_MAPPING(WKMediaSessionMetadataRef, WebMediaSessionMetadata)
>
> Why is this mapping #if'd out if WKMediaSessionMetadata has all the
> functions but the contents of said functions are if'd out? Which way are you
> disabling this?</span >
The contents of the functions have to be #if'd out since it doesn't seem like we can use #if ENABLE in those header files. I can remove the #if guards around the mapping.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>