[Webkit-unassigned] [Bug 146660] Media Session: propagate metadata changes to UI clients

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 06:39:28 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146660

--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 256258
  --> https://bugs.webkit.org/attachment.cgi?id=256258
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256258&action=review

> Source/WebKit2/Shared/WebMediaSessionMetadata.cpp:38
> +PassRefPtr<WebMediaSessionMetadata> WebMediaSessionMetadata::create(const MediaSessionMetadata& metadata)
> +{
> +    return adoptRef(new WebMediaSessionMetadata(metadata));
> +}

The return type should be Ref<WebMediaSessionMetadata>, not PassRefPtr<WebMediaSessionMetadata>. See http://www.webkit.org/coding/RefPtr.html.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150707/2be5010a/attachment.html>


More information about the webkit-unassigned mailing list