<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660">bug 146660</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256258&action=diff" name="attach_256258" title="Patch">attachment 256258</a> <a href="attachment.cgi?id=256258&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256258&action=review">https://bugs.webkit.org/attachment.cgi?id=256258&action=review</a>
<span class="quote">> Source/WebKit2/Shared/WebMediaSessionMetadata.cpp:38
> +PassRefPtr<WebMediaSessionMetadata> WebMediaSessionMetadata::create(const MediaSessionMetadata& metadata)
> +{
> + return adoptRef(new WebMediaSessionMetadata(metadata));
> +}</span >
The return type should be Ref<WebMediaSessionMetadata>, not PassRefPtr<WebMediaSessionMetadata>. See <a href="http://www.webkit.org/coding/RefPtr.html">http://www.webkit.org/coding/RefPtr.html</a>.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>