[Webkit-unassigned] [Bug 145979] Web Inspector: Pseudo Styles Ordering and Media Queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145979

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256072|review?                     |review+, commit-queue?
              Flags|                            |

--- Comment #6 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 256072
  --> https://bugs.webkit.org/attachment.cgi?id=256072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256072&action=review

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:278
> +                    if (style.ownerRule.selectorText.includes(pseudoElement.selectorText))

Do you really want includes? Or should this be a prefix or suffix match?

Comparing selectors might fail in some cases, like selectors with commas or implicit * (like :before is the same as *:before).

The lastMatchingSelector part is confusing to me. Can you explain it more, maybe with a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150703/9b6329d3/attachment.html>