<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Pseudo Styles Ordering and Media Queries"
href="https://bugs.webkit.org/show_bug.cgi?id=145979">bug 145979</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256072 Flags</td>
<td>review?
</td>
<td>review+, commit-queue?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Pseudo Styles Ordering and Media Queries"
href="https://bugs.webkit.org/show_bug.cgi?id=145979#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Pseudo Styles Ordering and Media Queries"
href="https://bugs.webkit.org/show_bug.cgi?id=145979">bug 145979</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256072&action=diff" name="attach_256072" title="Patch">attachment 256072</a> <a href="attachment.cgi?id=256072&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256072&action=review">https://bugs.webkit.org/attachment.cgi?id=256072&action=review</a>
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:278
> + if (style.ownerRule.selectorText.includes(pseudoElement.selectorText))</span >
Do you really want includes? Or should this be a prefix or suffix match?
Comparing selectors might fail in some cases, like selectors with commas or implicit * (like :before is the same as *:before).
The lastMatchingSelector part is confusing to me. Can you explain it more, maybe with a comment.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>