[Webkit-unassigned] [Bug 140935] [GTK] Resize the redirected XComposite window again after leaving accelerated compositing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140935

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 245440 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245440&action=review
> 
> Awesome fix.

Thanks.

> > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:219
> > +    XResizeWindow(m_display, m_window, std::max(1, size.width()), std::max(1, size.height()));
> 
> Perhaps a comment explaining that 0x0 windows are not allowed by X...

Sure.

> > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:259
> > +        std::max(1, m_size.width()), std::max(1, m_size.height())));
> 
> Ditto.

I've realized we don't need this, since we are going to assert for empty sizes here.

> Orthogonal to this we should probably assert in ::surface() if we aren't in
> AC.

Sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150130/725b0c41/attachment-0002.html>