[Webkit-unassigned] [Bug 140935] [GTK] Resize the redirected XComposite window again after leaving accelerated compositing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140935

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245440|review?                     |review+
              Flags|                            |

--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 245440
  --> https://bugs.webkit.org/attachment.cgi?id=245440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245440&action=review

Awesome fix.

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:219
> +    XResizeWindow(m_display, m_window, std::max(1, size.width()), std::max(1, size.height()));

Perhaps a comment explaining that 0x0 windows are not allowed by X...

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:259
> +        std::max(1, m_size.width()), std::max(1, m_size.height())));

Ditto.

Orthogonal to this we should probably assert in ::surface() if we aren't in AC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150129/2364a201/attachment-0002.html>