[Webkit-unassigned] [Bug 140307] If building with ASan, copy libclang_rt.asan_osx_dynamic.dylib to the build directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140307

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244793|review?                     |review-
              Flags|                            |

--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 244793
  --> https://bugs.webkit.org/attachment.cgi?id=244793
New target for DumpRenderTree which copies the dylib

View in context: https://bugs.webkit.org/attachment.cgi?id=244793&action=review

r- to address Mark's and Alexey's comments.

> Tools/ChangeLog:10
> +        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add a new target which runs copy-asan-dylib.
> +        * Scripts/copy-asan-dylib: Added. This script checks to see if we are building with asan, and
> +        if so, copies libclang_rt.asan_osx_dynamic.dylib to the build directory.

Xcode has a built-in way to copy files; can we just use a "copy files" build phase instead of a build phase script?

Or do we only need to copy this when building for ASan, so we have to include logic in the copy files build phase?

>> Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:738
>> +			buildWorkingDirectory = ../Scripts;
> 
> This violates some of our assumptions that projects don't require access content outside of their source root. DRT already violates this assumption in other places, but we should be trying to address those rather than making things worse.

In other words, please move this script into Tools/DumpRenderTree.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150120/429841ea/attachment-0002.html>