[Webkit-unassigned] [Bug 140307] If building with ASan, copy libclang_rt.asan_osx_dynamic.dylib to the build directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140307

--- Comment #5 from Mark Rowe (bdash) <mrowe at apple.com> ---
Comment on attachment 244793
  --> https://bugs.webkit.org/attachment.cgi?id=244793
New target for DumpRenderTree which copies the dylib

View in context: https://bugs.webkit.org/attachment.cgi?id=244793&action=review

> Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:738
> +			buildWorkingDirectory = ../Scripts;

This violates some of our assumptions that projects don't require access content outside of their source root. DRT already violates this assumption in other places, but we should be trying to address those rather than making things worse.

> Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:1153
> +			buildSettings = {
> +				ALWAYS_SEARCH_USER_PATHS = NO;
> +				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
> +				CLANG_CXX_LIBRARY = "libc++";
> +				CLANG_ENABLE_MODULES = YES;
> +				CLANG_ENABLE_OBJC_ARC = YES;

Please use .xcconfig files rather than including this gunk in the project. Please also filter out the irrelevant bits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150116/4b5f40db/attachment-0002.html>