[Webkit-unassigned] [Bug 140610] [GTK] Add API to change the WebKitWebView background color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140610

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 244887 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244887&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:339
> > +#if PLATFORM(GTK)
> > +    , m_backgroundColor(Color::white)
> > +#endif
> 
> I read your description of its behaviour on the list:
> 
>   - WebPageProxy::setDrawsBackground(): This ends up calling
> FrameView::setTransparent() for every frame. It seems that when this is set
> to true the document or base background color is ignored.
> 
> There is a base background color already, then, can we use that instead of
> adding something else? Otherwise looks good!

Not sure I understand what you mean. When we set drawsBrackground to False, WebCore doesn't render any background (unless the document itself specifies a background in the HTML or CSS). The default base color in FrameView is white, so when the white color is set by the user, we simply set the drawsBackground to True, and we don't need to fill our backing store. We need to initialize the WebPageProxy bg color member to white because we are comparing that value when a new color is set. If white color is set the first time, we simply do nothing, because that's already the default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150120/01823eed/attachment-0002.html>