[Webkit-unassigned] [Bug 140610] [GTK] Add API to change the WebKitWebView background color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140610

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244887|review?                     |review+
              Flags|                            |

--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org> ---
Comment on attachment 244887
  --> https://bugs.webkit.org/attachment.cgi?id=244887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244887&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:339
> +#if PLATFORM(GTK)
> +    , m_backgroundColor(Color::white)
> +#endif

I read your description of its behaviour on the list:

  - WebPageProxy::setDrawsBackground(): This ends up calling FrameView::setTransparent() for every frame. It seems that when this is set to true the document or base background color is ignored.

There is a base background color already, then, can we use that instead of adding something else? Otherwise looks good!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150119/54e85e77/attachment-0002.html>