[Webkit-unassigned] [Bug 140608] REGRESSION(r178527): It broke the !ENABLE(INSPECTOR) build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140608

--- Comment #4 from Csaba Osztrogonác <ossy at webkit.org> ---
(In reply to comment #2)
> Given that we use the logic in Inspector::ConsoleMessage even when inspector
> is not enabled, yes, this logic needs to be always compiled in. I haven't
> looked into how much of other Inspector code it uses. Perhaps it can be
> factored out of Inspector::ConsoleMessage.
> 
> What is the rationale for disabling Inspector? The !ENABLE(INSPECTOR) build
> appears to be very high maintenance.

It can be useful to reduce the binary codesize on embedded 
systems where you don't need inspector at all. 
( https://bugs.webkit.org/show_bug.cgi?id=140098#c5 )

I don't have strong opinion about it, but I don't like broken and unmaintained
ifdef guards. If we want to have a guard, we should maintain it, if we don't
want to maintain it, let's remove the guard.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150119/933ba53c/attachment-0002.html>