[Webkit-unassigned] [Bug 140608] REGRESSION(r178527): It broke the !ENABLE(INSPECTOR) build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140608

Brian Burg <burg at cs.washington.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timothy at apple.com

--- Comment #3 from Brian Burg <burg at cs.washington.edu> ---
(In reply to comment #1)
> Does r178527 mean that inspector is mandatory feature since now? 
> 
> If yes, let's remove the compile time guards and make it really mandatory.
> If no, could you possibly give me any hint how to fix the build properly?

It seems that these are the only methods that actually require ENABLE(INSPECTOR), and are entry points from InspectorConsoleAgent:

    void addToFrontend(InspectorConsoleFrontendDispatcher*, InjectedScriptManager*, bool generatePreview);
    void updateRepeatCountInConsole(InspectorConsoleFrontendDispatcher*);

Plus IdentifiersFactory.h which looks to have no other Inspector dependencies. So you would need to remove the guard of the entire file and only surround those methods (and their static helper functions in the .cpp file).

Honestly, someone should request to webkit-dev to remove ENABLE(INSPECTOR) guards. There are no bots running this configuration, and I would be surprised if anyone contributing to trunk depends on it. If such a person exists, I would have expected to hear about these build breaks before Ossy found it via --minimal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150119/bf4b9391/attachment-0002.html>