[Webkit-unassigned] [Bug 139813] [MSE] Implement per TrackBuffer buffered.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139813

--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 244596
  --> https://bugs.webkit.org/attachment.cgi?id=244596
add per trackBuffer buffered + layoutTests

View in context: https://bugs.webkit.org/attachment.cgi?id=244596&action=review

This is great. What I'd like to see added, but maybe in another patch, is caching of buffered ranges at the MediaSource level. Right now, an expensive merge step happens every time someone requests buffered().

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:821
> +    recalculateBuffered();

The way we do this in other places, like HTMLMediaElement, is that instead of recalculating the cached value immediately when its invalidated, we mark it as dirty and only recalculate the value when asked.  This would mean replacing all your instances of "recalculateBuffered()" to something like "invalidateBuffered()", and call "recalculateBuffered()" from within "buffered()" if the value is invalidated.

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1615
> +    recalculateBuffered();

This is probably more often than necessary. You could call this (or invalidate buffered) from sourceBufferPrivateAppendComplete().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150114/7da09059/attachment-0002.html>