[Webkit-unassigned] [Bug 140116] [GStreamer][MSE] ASSERT in MediaSourceGStreamer::addSourceBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140116

--- Comment #11 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 244058
  --> https://bugs.webkit.org/attachment.cgi?id=244058
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244058&action=review

> Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:68
> +    SourceBufferPrivateClient::AppendResult result = m_mediaSource->client()->append(this, data, length);

Not in the scope of this bug, but MediaSourceClientGStreamer::append() doesn't have to operate on a PassRefPtr<SourceBufferPrivate> -- a simple reference to the SourceBufferPrivate object would do.

> Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:85
> +    m_mediaSource->client()->removedFromMediaSource(this);

Same here, MediaSourceClientGStreamer::removedFromMediaSource() could operate with a reference to the SourceBufferPrivate object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150108/71d62104/attachment-0002.html>